Fix Storage State in Carbonado #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoquick
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
Sure, this should be fine. We really should get an automerge implementation of #268, however, I think that would resolve all these issues.
crisdut
force-pushed
the
CD/fix-storage
branch
from
153195b to
8f6f401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found a problem with carbonado overwriting file verification when we use wasm32 (see here).
After running consecutive transfers (more than 100x), the rgb_wallet or stock ends up having a minimum variation of bytes downwards, which ends up being unsaved, and this causes some issues in contract states (@josediegorobles I believe this causes some inconsistencies in the balances you reported).
This PR still needs to be completed, I need some help to test it.